[MIRROR] Add the Donk Manufacturer to toy guns that lacked it #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Donkification TF pistol was a scarborough lol * remove a duplicate line oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#4774
About The Pull Request
We have a Donk Corporation manufacturer specifically for the toy firearms, but the Donksoft Pistol and Donksoft SMG were both missed. The pistol was a scarborough and the SMG had no manufacturer. Remedies this and gives them the same manufacturer as the rest of the Donksoft guns.
How This Contributes To The Nova Sector Roleplay Experience
Consistency is good. Also, Scarboroughs are critcon, and probably shouldn't be in station vendors.
Proof of Testing
Screenshots/Videos
Changelog
🆑 LordHookie
fix: Donk Soft 'sidearms' now use the Donk. Co label instead of missing one or being scarborough
/:cl: